Commit afa4b293 authored by Kevin Wolf's avatar Kevin Wolf
Browse files

block: Assertions for write permissions 



This adds assertions that ensure that the necessary write permissions
have been granted before someone attempts to write to a node.

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Acked-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
parent 85c97ca7

block/io.c

+3 −0
Original line number Diff line number Diff line
@@ -945,6 +945,8 @@ static int coroutine_fn bdrv_co_do_copy_on_readv(BdrvChild *child, 
    size_t skip_bytes;

    int ret;



    assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE));



    /* Cover entire cluster so no additional backing file I/O is required when

     * allocating cluster in the image file.

     */
@@ -1336,6 +1338,7 @@ static int coroutine_fn bdrv_aligned_pwritev(BdrvChild *child, 
    assert(!waited || !req->serialising);

    assert(req->overlap_offset <= offset);

    assert(offset + bytes <= req->overlap_offset + req->overlap_bytes);

    assert(child->perm & BLK_PERM_WRITE);



    ret = notifier_with_return_list_notify(&bs->before_write_notifiers, req);