Commit af8ad96b authored by David Gibson's avatar David Gibson
Browse files

spapr: Start hotplugged PCI devices in ISOLATED state 



PCI DRCs, and only PCI DRCs, are immediately moved to UNISOLATED isolation
state once the device is attached.  This has been there from the initial
implementation, and it's not clear why.

The state diagram in PAPR 13.4 suggests PCI devices should start in
ISOLATED state until the guest moves them into UNISOLATED, and the code in
the guest-side drmgr tool seems to work that way too.

Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Reviewed-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
parent ddd5140b

hw/ppc/spapr_drc.c

+0 −10
Original line number Diff line number Diff line
@@ -304,16 +304,6 @@ void spapr_drc_attach(sPAPRDRConnector *drc, DeviceState *d, void *fdt, 
    }

    g_assert(fdt || coldplug);



    /* NOTE: setting initial isolation state to UNISOLATED means we can't

     * detach unless guest has a userspace/kernel that moves this state

     * back to ISOLATED in response to an unplug event, or this is done

     * manually by the admin prior. if we force things while the guest

     * may be accessing the device, we can easily crash the guest, so we

     * we defer completion of removal in such cases to the reset() hook.

     */

    if (spapr_drc_type(drc) == SPAPR_DR_CONNECTOR_TYPE_PCI) {

        drc->isolation_state = SPAPR_DR_ISOLATION_STATE_UNISOLATED;

    }

    drc->dr_indicator = SPAPR_DR_INDICATOR_ACTIVE;



    drc->dev = d;