Commit aeab8e5e authored by Alex Bennée's avatar Alex Bennée Committed by Peter Maydell
Browse files

target/arm: fix TCG leak for fcvt half->double 



When support for the AHP flag was added we inexplicably only freed the
new temps in one of the two legs. Move those tcg_temp_free to the same
level as the allocation to fix that leak.

Fixes: 486624fc
Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Message-id: 20200131153439.26027-1-alex.bennee@linaro.org
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent adcd6e93

target/arm/translate-a64.c

+2 −2
Original line number Diff line number Diff line
@@ -5778,8 +5778,6 @@ static void handle_fp_fcvt(DisasContext *s, int opcode, 
            TCGv_i32 tcg_rd = tcg_temp_new_i32();

            gen_helper_vfp_fcvt_f16_to_f32(tcg_rd, tcg_rn, tcg_fpst, tcg_ahp);

            write_fp_sreg(s, rd, tcg_rd);

            tcg_temp_free_ptr(tcg_fpst);

            tcg_temp_free_i32(tcg_ahp);

            tcg_temp_free_i32(tcg_rd);

        } else {

            /* Half to double */
@@ -5789,6 +5787,8 @@ static void handle_fp_fcvt(DisasContext *s, int opcode, 
            tcg_temp_free_i64(tcg_rd);

        }

        tcg_temp_free_i32(tcg_rn);

        tcg_temp_free_ptr(tcg_fpst);

        tcg_temp_free_i32(tcg_ahp);

        break;

    }

    default: