Commit ae765180 authored by Peter Maydell's avatar Peter Maydell
Browse files

tcg: Optionally log FPU state in TCG -d cpu logging 



Usually the logging of the CPU state produced by -d cpu is sufficient
to diagnose problems, but sometimes you want to see the state of
the floating point registers as well. We don't want to enable that
by default as it adds a lot of extra data to the log; instead,
allow it to be optionally enabled via -d fpu.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Message-id: 20180510130024.31678-1-peter.maydell@linaro.org
parent f6fb1f9b

accel/tcg/cpu-exec.c

+6 −3
Original line number Diff line number Diff line
@@ -156,11 +156,14 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu, TranslationBlock *itb) 
    if (qemu_loglevel_mask(CPU_LOG_TB_CPU)

        && qemu_log_in_addr_range(itb->pc)) {

        qemu_log_lock();

        int flags = 0;

        if (qemu_loglevel_mask(CPU_LOG_TB_FPU)) {

            flags |= CPU_DUMP_FPU;

        }

#if defined(TARGET_I386)

        log_cpu_state(cpu, CPU_DUMP_CCOP);

#else

        log_cpu_state(cpu, 0);

        flags |= CPU_DUMP_CCOP;

#endif

        log_cpu_state(cpu, flags);

        qemu_log_unlock();

    }

#endif /* DEBUG_DISAS */

include/qemu/log.h

+1 −0
Original line number Diff line number Diff line
@@ -44,6 +44,7 @@ static inline bool qemu_log_separate(void) 
#define CPU_LOG_PAGE       (1 << 14)

/* LOG_TRACE (1 << 15) is defined in log-for-trace.h */

#define CPU_LOG_TB_OP_IND  (1 << 16)

#define CPU_LOG_TB_FPU     (1 << 17)



/* Lock output for a series of related logs.  Since this is not needed

 * for a single qemu_log / qemu_log_mask / qemu_log_mask_and_addr, we

util/log.c

+2 −0
Original line number Diff line number Diff line
@@ -256,6 +256,8 @@ const QEMULogItem qemu_log_items[] = { 
      "show trace before each executed TB (lots of logs)" },

    { CPU_LOG_TB_CPU, "cpu",

      "show CPU registers before entering a TB (lots of logs)" },

    { CPU_LOG_TB_FPU, "fpu",

      "include FPU registers in the 'cpu' logging" },

    { CPU_LOG_MMU, "mmu",

      "log MMU-related activities" },

    { CPU_LOG_PCALL, "pcall",