Commit ae14d817 authored by Mark Cave-Ayland's avatar Mark Cave-Ayland Committed by David Gibson
Browse files

cuda: don't allow writes to port output pins 



Use the direction registers as a mask to ensure that only input pins are
updated upon write.

Signed-off-by: default avatarMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: default avatarLaurent Vivier <lvivier@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 8d0ef282

hw/misc/macio/cuda.c

+2 −2
Original line number Diff line number Diff line
@@ -359,11 +359,11 @@ static void cuda_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) 


    switch(addr) {

    case CUDA_REG_B:

        s->b = val;

        s->b = (s->b & ~s->dirb) | (val & s->dirb);

        cuda_update(s);

        break;

    case CUDA_REG_A:

        s->a = val;

        s->a = (s->a & ~s->dira) | (val & s->dira);

        break;

    case CUDA_REG_DIRB:

        s->dirb = val;