Commit adc71666 authored by Aurelien Jarno's avatar Aurelien Jarno
Browse files

target-i386: fix round{pd,ps,sd,ss} SSE2 instructions 



roundps and roundss SSE2 instructions have been broken when switching
target-i386 to softfloat. They use float64_round_to_int to convert a
float32, and while the implicit conversion from float32 to float64 was
correct for softfloat-native, it is not for pure softfloat. Fix that by
using the correct registers and correct functions.

Also fix roundpd and roundsd implementation at the same time, even if
these functions are behaving correctly.

Signed-off-by: default avatarAurelien Jarno <aurelien@aurel32.net>
parent a4d1f142

target-i386/ops_sse.h

+8 −8
Original line number Diff line number Diff line
@@ -1653,10 +1653,10 @@ void glue(helper_roundps, SUFFIX) (Reg *d, Reg *s, uint32_t mode) 
            break;

        }



    d->L(0) = float64_round_to_int(s->L(0), &env->sse_status);

    d->L(1) = float64_round_to_int(s->L(1), &env->sse_status);

    d->L(2) = float64_round_to_int(s->L(2), &env->sse_status);

    d->L(3) = float64_round_to_int(s->L(3), &env->sse_status);

    d->XMM_S(0) = float32_round_to_int(s->XMM_S(0), &env->sse_status);

    d->XMM_S(1) = float32_round_to_int(s->XMM_S(1), &env->sse_status);

    d->XMM_S(2) = float32_round_to_int(s->XMM_S(2), &env->sse_status);

    d->XMM_S(3) = float32_round_to_int(s->XMM_S(3), &env->sse_status);



#if 0 /* TODO */

    if (mode & (1 << 3))
@@ -1689,8 +1689,8 @@ void glue(helper_roundpd, SUFFIX) (Reg *d, Reg *s, uint32_t mode) 
            break;

        }



    d->Q(0) = float64_round_to_int(s->Q(0), &env->sse_status);

    d->Q(1) = float64_round_to_int(s->Q(1), &env->sse_status);

    d->XMM_D(0) = float64_round_to_int(s->XMM_D(0), &env->sse_status);

    d->XMM_D(1) = float64_round_to_int(s->XMM_D(1), &env->sse_status);



#if 0 /* TODO */

    if (mode & (1 << 3))
@@ -1723,7 +1723,7 @@ void glue(helper_roundss, SUFFIX) (Reg *d, Reg *s, uint32_t mode) 
            break;

        }



    d->L(0) = float64_round_to_int(s->L(0), &env->sse_status);

    d->XMM_S(0) = float32_round_to_int(s->XMM_S(0), &env->sse_status);



#if 0 /* TODO */

    if (mode & (1 << 3))
@@ -1756,7 +1756,7 @@ void glue(helper_roundsd, SUFFIX) (Reg *d, Reg *s, uint32_t mode) 
            break;

        }



    d->Q(0) = float64_round_to_int(s->Q(0), &env->sse_status);

    d->XMM_D(0) = float64_round_to_int(s->XMM_D(0), &env->sse_status);



#if 0 /* TODO */

    if (mode & (1 << 3))