Commit ad3a7e45 authored by Logan Gunthorpe's avatar Logan Gunthorpe Committed by Kevin Wolf
Browse files

nvme: fix bug with PCI IRQ pins on teardown 



When the submission and completion queues are being torn down
the IRQ will be asserted for the completion queue when the
submsission queue is deleted. Then when the completion queue
is deleted it stays asserted. Thus, on systems that do
not use MSI, no further interrupts can be triggered on the host.

Linux sees this as a long delay when unbinding the nvme device.
Eventually the interrupt timeout occurs and it continues.

To fix this we ensure we deassert the IRQ for a CQ when it is
deleted.

Signed-off-by: default avatarLogan Gunthorpe <logang@deltatee.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 71a86dde

hw/block/nvme.c

+1 −0
Original line number Diff line number Diff line
@@ -554,6 +554,7 @@ static uint16_t nvme_del_cq(NvmeCtrl *n, NvmeCmd *cmd) 
        trace_nvme_err_invalid_del_cq_notempty(qid);

        return NVME_INVALID_QUEUE_DEL;

    }

    nvme_irq_deassert(n, cq);

    trace_nvme_del_cq(qid);

    nvme_free_cq(cq, n);

    return NVME_SUCCESS;