Commit ad14a46a authored by Greg Kurz's avatar Greg Kurz Committed by Michael S. Tsirkin
Browse files

virtio-scsi: handle virtio_scsi_set_config() error 



This error is caused by a buggy guest: let's switch the device to the
broken state instead of terminating QEMU.

Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 661e32fb

hw/scsi/virtio-scsi.c

+3 −2
Original line number Diff line number Diff line
@@ -644,8 +644,9 @@ static void virtio_scsi_set_config(VirtIODevice *vdev, 


    if ((uint32_t) virtio_ldl_p(vdev, &scsiconf->sense_size) >= 65536 ||

        (uint32_t) virtio_ldl_p(vdev, &scsiconf->cdb_size) >= 256) {

        error_report("bad data written to virtio-scsi configuration space");

        exit(1);

        virtio_error(vdev,

                     "bad data written to virtio-scsi configuration space");

        return;

    }



    vs->sense_size = virtio_ldl_p(vdev, &scsiconf->sense_size);