Commit ac90dad9 authored by Jeff Cody's avatar Jeff Cody
Browse files

block/sheepdog: remove spurious NULL check 



'tag' is already checked in the lines immediately preceding this check,
and set to non-NULL if NULL.  No need to check again, it hasn't changed.

Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarDarren Kenny <darren.kenny@oracle.com>
Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
parent aa9ef2e6

block/sheepdog.c

+1 −1
Original line number Diff line number Diff line
@@ -1632,7 +1632,7 @@ static int sd_open(BlockDriverState *bs, QDict *options, int flags, 
    if (!tag) {

        tag = "";

    }

    if (tag && strlen(tag) >= SD_MAX_VDI_TAG_LEN) {

    if (strlen(tag) >= SD_MAX_VDI_TAG_LEN) {

        error_setg(errp, "value of parameter 'tag' is too long");

        ret = -EINVAL;

        goto err_no_fd;