Commit ab44c7b7 authored by Peter Maydell's avatar Peter Maydell
Browse files

target/arm: Initialize ARMMMUFaultInfo in v7m_stack_read/write 



The get_phys_addr() functions take a pointer to an ARMMMUFaultInfo
struct, which they fill in only if a fault occurs. This means that
the caller must always zero-initialize the struct before passing
it in. We forgot to do this in v7m_stack_read() and v7m_stack_write().
Correct the error.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Message-id: 20181011172057.9466-1-peter.maydell@linaro.org
parent 599b71e2

target/arm/helper.c

+2 −2
Original line number Diff line number Diff line
@@ -6472,7 +6472,7 @@ static bool v7m_stack_write(ARMCPU *cpu, uint32_t addr, uint32_t value, 
    target_ulong page_size;

    hwaddr physaddr;

    int prot;

    ARMMMUFaultInfo fi;

    ARMMMUFaultInfo fi = {};

    bool secure = mmu_idx & ARM_MMU_IDX_M_S;

    int exc;

    bool exc_secure;
@@ -6534,7 +6534,7 @@ static bool v7m_stack_read(ARMCPU *cpu, uint32_t *dest, uint32_t addr, 
    target_ulong page_size;

    hwaddr physaddr;

    int prot;

    ARMMMUFaultInfo fi;

    ARMMMUFaultInfo fi = {};

    bool secure = mmu_idx & ARM_MMU_IDX_M_S;

    int exc;

    bool exc_secure;