Commit ab3ad07f authored by Markus Armbruster's avatar Markus Armbruster Committed by Paolo Bonzini
Browse files

x86: Use g_new() & friends where that makes obvious sense 



g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
for two reasons.  One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.

This commit only touches allocations with size arguments of the form
sizeof(T).

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 4be34d1e

hw/i386/pc.c

+1 −2
Original line number Diff line number Diff line
@@ -601,8 +601,7 @@ int e820_add_entry(uint64_t address, uint64_t length, uint32_t type) 
    }



    /* new "etc/e820" file -- include ram too */

    e820_table = g_realloc(e820_table,

                           sizeof(struct e820_entry) * (e820_entries+1));

    e820_table = g_renew(struct e820_entry, e820_table, e820_entries + 1);

    e820_table[e820_entries].address = cpu_to_le64(address);

    e820_table[e820_entries].length = cpu_to_le64(length);

    e820_table[e820_entries].type = cpu_to_le32(type);

target-i386/kvm.c

+1 −1
Original line number Diff line number Diff line
@@ -278,7 +278,7 @@ static void kvm_hwpoison_page_add(ram_addr_t ram_addr) 
            return;

        }

    }

    page = g_malloc(sizeof(HWPoisonPage));

    page = g_new(HWPoisonPage, 1);

    page->ram_addr = ram_addr;

    QLIST_INSERT_HEAD(&hwpoison_page_list, page, list);

}