Commit aaa1e77f authored by Alberto Garcia's avatar Alberto Garcia Committed by Stefan Hajnoczi
Browse files

throttle: Don't allow burst limits to be lower than the normal limits 

Setting FOO_max to a value that is lower than FOO does not make
sense, and it produces odd results depending on the value of
FOO_max_length. Although the user should not set that configuration
in the first place it's better to reject it explicitly.

https://bugzilla.redhat.com/show_bug.cgi?id=1355665



Signed-off-by: default avatarAlberto Garcia <berto@igalia.com>
Reported-by: default avatarGu Nini <ngu@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Message-id: 663d5aca406060e31f80d8113f77b6feee63b919.1469693110.git.berto@igalia.com
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 555a608c

util/throttle.c

+5 −0
Original line number Diff line number Diff line
@@ -348,6 +348,11 @@ bool throttle_is_valid(ThrottleConfig *cfg, Error **errp) 
                       " bps/iops values");

            return false;

        }



        if (cfg->buckets[i].max && cfg->buckets[i].max < cfg->buckets[i].avg) {

            error_setg(errp, "bps_max/iops_max cannot be lower than bps/iops");

            return false;

        }

    }



    return true;