Commit aa369e5c authored by Peter Maydell's avatar Peter Maydell
Browse files

target/arm: Add v8M stack checks for Thumb push/pop 



Add v8M stack checks for the 16-bit Thumb push/pop
encodings: STMDB, STMFD, LDM, LDMIA, LDMFD.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Message-id: 20181002163556.10279-12-peter.maydell@linaro.org
parent 0bc003ba

target/arm/translate.c

+15 −1
Original line number Diff line number Diff line
@@ -12251,7 +12251,10 @@ static void disas_thumb_insn(DisasContext *s, uint32_t insn) 
            store_reg(s, rd, tmp);

            break;

        case 4: case 5: case 0xc: case 0xd:

            /* push/pop */

            /*

             * 0b1011_x10x_xxxx_xxxx

             *  - push/pop

             */

            addr = load_reg(s, 13);

            if (insn & (1 << 8))

                offset = 4;
@@ -12264,6 +12267,17 @@ static void disas_thumb_insn(DisasContext *s, uint32_t insn) 
            if ((insn & (1 << 11)) == 0) {

                tcg_gen_addi_i32(addr, addr, -offset);

            }



            if (s->v8m_stackcheck) {

                /*

                 * Here 'addr' is the lower of "old SP" and "new SP";

                 * if this is a pop that starts below the limit and ends

                 * above it, it is UNKNOWN whether the limit check triggers;

                 * we choose to trigger.

                 */

                gen_helper_v8m_stackcheck(cpu_env, addr);

            }



            for (i = 0; i < 8; i++) {

                if (insn & (1 << i)) {

                    if (insn & (1 << 11)) {