Commit aa1530de authored by Eduardo Otubo's avatar Eduardo Otubo Committed by Michael Tokarev
Browse files

filter-mirror: segfault when specifying non existent device 



When using filter-mirror like the example below where the interface
'ndev0' does not exist on the host, QEMU crashes into segmentation
fault.

 $ qemu-system-x86_64 -S -machine pc -netdev user,id=ndev0 -object filter-mirror,id=test-object,netdev=ndev0

This happens because the function filter_mirror_setup() does not check
if the device actually exists and still keep on processing calling
qemu_chr_find(). This patch fixes this issue.

Signed-off-by: default avatarEduardo Otubo <otubo@redhat.com>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent 534fd814

net/filter-mirror.c

+6 −0
Original line number Diff line number Diff line
@@ -213,6 +213,12 @@ static void filter_mirror_setup(NetFilterState *nf, Error **errp) 
    MirrorState *s = FILTER_MIRROR(nf);

    Chardev *chr;



    if (s->outdev == NULL) {

        error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND, "filter-mirror parameter"\

                  " 'outdev' cannot be empty");

        return;

    }



    chr = qemu_chr_find(s->outdev);

    if (chr == NULL) {

        error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,