Commit a904c911 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

exec: fix madvise of NULL pointer 



Coverity flags this as "dereference after null check".  Not quite a
dereference, since it will just EFAULT, but still nice to fix.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent dd858343

exec.c

+7 −6
Original line number Diff line number Diff line
@@ -1386,13 +1386,14 @@ static ram_addr_t ram_block_add(RAMBlock *new_block, Error **errp) 
    cpu_physical_memory_set_dirty_range(new_block->offset,

                                        new_block->used_length);



    if (new_block->host) {

        qemu_ram_setup_dump(new_block->host, new_block->max_length);

        qemu_madvise(new_block->host, new_block->max_length, QEMU_MADV_HUGEPAGE);

        qemu_madvise(new_block->host, new_block->max_length, QEMU_MADV_DONTFORK);



        if (kvm_enabled()) {

            kvm_setup_guest_memory(new_block->host, new_block->max_length);

        }

    }



    return new_block->offset;

}