Commit a8bba0ad authored by Thomas Huth's avatar Thomas Huth Committed by Michael S. Tsirkin
Browse files

virtio: Tell the user what went wrong when event_notifier_init failed 



event_notifier_init() can fail in real life, for example when there
are not enough open file handles available (EMFILE) when using a lot
of devices. So instead of leaving the average user with a cryptic
error number only, print out a proper error message with strerror()
instead, so that the user has a better way to figure out what is
going on and that using "ulimit -n" might help here for example.

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent c2a57aae

hw/virtio/virtio-bus.c

+2 −1
Original line number Diff line number Diff line
@@ -164,7 +164,8 @@ static int set_host_notifier_internal(DeviceState *proxy, VirtioBusState *bus, 
    if (assign) {

        r = event_notifier_init(notifier, 1);

        if (r < 0) {

            error_report("%s: unable to init event notifier: %d", __func__, r);

            error_report("%s: unable to init event notifier: %s (%d)",

                         __func__, strerror(-r), r);

            return r;

        }

        virtio_queue_set_host_notifier_fd_handler(vq, true, set_handler);