Commit a808c086 authored by Thomas Huth's avatar Thomas Huth Committed by Michael Tokarev
Browse files

hw/misc/mmio_interface: Return after error_setg() to avoid crash 



QEMU currently abort()s if the user tries to specify the mmio_interface
device without parameters:

x86_64-softmmu/qemu-system-x86_64 -nographic -device mmio_interface
qemu-system-x86_64: /home/thuth/devel/qemu/util/error.c:57: error_setv:
 Assertion `*errp == ((void *)0)' failed.
Aborted (core dumped)

This happens because the realize function is trying to set the errp
twice in this case. After setting an error, the realize function
should immediately return instead.

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent a3e08c2d

hw/misc/mmio_interface.c

+2 −0
Original line number Diff line number Diff line
@@ -63,10 +63,12 @@ static void mmio_interface_realize(DeviceState *dev, Error **errp) 


    if (!s->host_ptr) {

        error_setg(errp, "host_ptr property must be set");

        return;

    }



    if (!s->subregion) {

        error_setg(errp, "subregion property must be set");

        return;

    }



    memory_region_init_ram_ptr(&s->ram_mem, OBJECT(s), "ram",