Commit a8003ec4 authored by Alberto Garcia's avatar Alberto Garcia Committed by Kevin Wolf
Browse files

qemu-io: Fix writethrough check in reopen 



"qemu-io reopen" doesn't allow changing the writethrough setting of
the cache, but the check is wrong, causing an error even on a simple
reopen with the default parameters:

   $ qemu-img create -f qcow2 hd.qcow2 1M
   $ qemu-system-x86_64 -monitor stdio -drive if=virtio,file=hd.qcow2
   (qemu) qemu-io virtio0 reopen
   Cannot change cache.writeback: Device attached

Signed-off-by: default avatarAlberto Garcia <berto@igalia.com>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent b857431d

qemu-io-cmds.c

+1 −1
Original line number Diff line number Diff line
@@ -2025,7 +2025,7 @@ static int reopen_f(BlockBackend *blk, int argc, char **argv) 
        return -EINVAL;

    }



    if (writethrough != blk_enable_write_cache(blk) &&

    if (!writethrough != blk_enable_write_cache(blk) &&

        blk_get_attached_dev(blk))

    {

        error_report("Cannot change cache.writeback: Device attached");