Commit a77cffe7 authored by Stefan Weil's avatar Stefan Weil Committed by Kevin Wolf
Browse files

block: Use GCC_FMT_ATTR and fix a format error 



Adding the gcc format attribute detects a format bug
which is fixed here.

v2:
Don't use type cast. BDRV_SECTOR_SIZE is unsigned long long,
so %lld should be the correct format specifier.

Cc: Blue Swirl <blauwirbel@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: default avatarStefan Weil <weil@mail.berlios.de>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 191c2890

block/blkverify.c

+3 −2
Original line number Diff line number Diff line
@@ -53,7 +53,8 @@ static AIOPool blkverify_aio_pool = { 
    .cancel             = blkverify_aio_cancel,

};



static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...)

static void GCC_FMT_ATTR(2, 3) blkverify_err(BlkverifyAIOCB *acb,

                                             const char *fmt, ...)

{

    va_list ap;
@@ -299,7 +300,7 @@ static void blkverify_verify_readv(BlkverifyAIOCB *acb) 
{

    ssize_t offset = blkverify_iovec_compare(acb->qiov, &acb->raw_qiov);

    if (offset != -1) {

        blkverify_err(acb, "contents mismatch in sector %ld",

        blkverify_err(acb, "contents mismatch in sector %lld",

                      acb->sector_num + (offset / BDRV_SECTOR_SIZE));

    }

}