Commit a6deecce authored by Sven Schnelle's avatar Sven Schnelle Committed by Richard Henderson
Browse files

target/hppa: prevent trashing of temporary in do_depw_sar() 



nullify_over() calls brcond which destroys all temporaries.

Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: default avatarSven Schnelle <svens@stackframe.org>
Message-Id: <20190913101714.29019-3-svens@stackframe.org>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
parent 4845f015

target/hppa/translate.c

+6 −4
Original line number Diff line number Diff line
@@ -3404,10 +3404,6 @@ static bool do_depw_sar(DisasContext *ctx, unsigned rt, unsigned c, 
    TCGv_reg mask, tmp, shift, dest;

    unsigned msb = 1U << (len - 1);



    if (c) {

        nullify_over(ctx);

    }



    dest = dest_gpr(ctx, rt);

    shift = tcg_temp_new();

    tmp = tcg_temp_new();
@@ -3440,11 +3436,17 @@ static bool do_depw_sar(DisasContext *ctx, unsigned rt, unsigned c, 


static bool trans_depw_sar(DisasContext *ctx, arg_depw_sar *a)

{

    if (a->c) {

        nullify_over(ctx);

    }

    return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_gpr(ctx, a->r));

}



static bool trans_depwi_sar(DisasContext *ctx, arg_depwi_sar *a)

{

    if (a->c) {

        nullify_over(ctx);

    }

    return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_const(ctx, a->i));

}