Commit a5fe209d authored by Li Qiang's avatar Li Qiang Committed by Marcel Apfelbaum
Browse files

hw: rdma: fix an off-by-one issue 



In rdma_rm_get_backend_gid_index(), the 'sgid_idx' is used
to index the array 'dev_res->port.gid_tbl' which size is
MAX_PORT_GIDS. Current the 'sgid_idx' may be MAX_PORT_GIDS
thus cause an off-by-one issue.

Spotted by Coverity: CID 1398594

Signed-off-by: default avatarLi Qiang <liq3ea@163.com>
Message-Id: <20190103131251.49271-1-liq3ea@163.com>
Signed-off-by: default avatarMarcel Apfelbaum <marcel.apfelbaum@gmail.com>
parent a1aa88b7

hw/rdma/rdma_rm.c

+1 −1
Original line number Diff line number Diff line
@@ -579,7 +579,7 @@ int rdma_rm_del_gid(RdmaDeviceResources *dev_res, RdmaBackendDev *backend_dev, 
int rdma_rm_get_backend_gid_index(RdmaDeviceResources *dev_res,

                                  RdmaBackendDev *backend_dev, int sgid_idx)

{

    if (unlikely(sgid_idx < 0 || sgid_idx > MAX_PORT_GIDS)) {

    if (unlikely(sgid_idx < 0 || sgid_idx >= MAX_PORT_GIDS)) {

        pr_dbg("Got invalid sgid_idx %d\n", sgid_idx);

        return -EINVAL;

    }