Commit a5f99be4 authored by Miika S's avatar Miika S Committed by Gerd Hoffmann
Browse files

input: virtio: don't send mouse wheel event twice 



On Linux, a mouse event is generated for both down and up when mouse
wheel is used. This caused virtio_input_send() to be called twice each
time the wheel was used.

This commit adds a check for the button down state and only calls
virtio_input_send() when it is true.

Signed-off-by: default avatarMiika S <miika9764@gmail.com>
Message-Id: <20171222152531.1849-4-miika9764@gmail.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 2416760f

hw/input/virtio-input-hid.c

+4 −2
Original line number Diff line number Diff line
@@ -218,8 +218,10 @@ static void virtio_input_handle_event(DeviceState *dev, QemuConsole *src, 
        break;

    case INPUT_EVENT_KIND_BTN:

        btn = evt->u.btn.data;

        if (vhid->wheel_axis && (btn->button == INPUT_BUTTON_WHEEL_UP ||

                                 btn->button == INPUT_BUTTON_WHEEL_DOWN)) {

        if (vhid->wheel_axis &&

            (btn->button == INPUT_BUTTON_WHEEL_UP ||

             btn->button == INPUT_BUTTON_WHEEL_DOWN) &&

            btn->down) {

            event.type  = cpu_to_le16(EV_REL);

            event.code  = cpu_to_le16(REL_WHEEL);

            event.value = cpu_to_le32(btn->button == INPUT_BUTTON_WHEEL_UP