Commit a4543b1b authored by Shmulik Ladkani's avatar Shmulik Ladkani Committed by Jason Wang
Browse files

net: hmp_host_net_remove: Del the -net option of the removed host_net 



Upon hmp_host_net_remove(), the appropriate -net client is deleted
(according to the given vlan_id and device id), as well as the
corresponsing hub port.

However, the relevant '-net' option that was added by former
hmp_host_net_add() call is still present in "net" options group.

This makes the following legit HMP sequence erroneous:

(qemu) host_net_add tap id=n1,ifname=tap1,script=no,downscript=no,vlan=1
(qemu) host_net_remove 1 n1
(qemu) host_net_add tap id=n1,ifname=tap1,script=no,downscript=no,vlan=1
Duplicate ID 'n1' for net

Fix, by deleting the stored '-net' option associated with the given
device id.

Signed-off-by: default avatarShmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
parent 1c0fbfa3

net/net.c

+1 −0
Original line number Diff line number Diff line
@@ -1179,6 +1179,7 @@ void hmp_host_net_remove(Monitor *mon, const QDict *qdict) 


    qemu_del_net_client(nc->peer);

    qemu_del_net_client(nc);

    qemu_opts_del(qemu_opts_find(qemu_find_opts("net"), device));

}



void netdev_add(QemuOpts *opts, Error **errp)