Commit a4164270 authored by Gonglei's avatar Gonglei Committed by Gerd Hoffmann
Browse files

spice: fix memory leak 



If errors happen for middle items of channel_list,
qmp_query_spice_channels() returns NULL, and the variable
cur_item going out of scope leaks the storage it points to.

The flag is a compatibility thing for older spice-server
versions. Meanwhile our minimum spice version requirement is
new enough that we should never ever see this error, and if we
do something went very seriously wrong. Let's using assert()
instead of returning NULL to avoid a memory leak.

Suggested-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarGonglei <arei.gonglei@huawei.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent e0883e2d

ui/spice-core.c

+1 −4
Original line number Diff line number Diff line
@@ -385,10 +385,7 @@ static SpiceChannelList *qmp_query_spice_channels(void) 
        struct sockaddr *paddr;

        socklen_t plen;



        if (!(item->info->flags & SPICE_CHANNEL_EVENT_FLAG_ADDR_EXT)) {

            error_report("invalid channel event");

            return NULL;

        }

        assert(item->info->flags & SPICE_CHANNEL_EVENT_FLAG_ADDR_EXT);



        chan = g_malloc0(sizeof(*chan));

        chan->value = g_malloc0(sizeof(*chan->value));