Commit a32e900b authored by Greg Kurz's avatar Greg Kurz Committed by David Gibson
Browse files

spapr/drc: don't migrate DRC of cold-plugged CPUs and LMBs 



As explained in commit 5c0139a8 ("spapr: fix default DRC state for
coldplugged LMBs"), guests expect cold-plugged LMBs to be pre-allocated
and unisolated. The same goes for cold-plugged CPUs.

While here, let's convert g_assert(false) to the better self documenting
g_assert_not_reached().

Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent c4e13492

hw/ppc/spapr_drc.c

+3 −7
Original line number Diff line number Diff line
@@ -546,20 +546,16 @@ static bool spapr_drc_needed(void *opaque) 
     */

    switch (drc->type) {

    case SPAPR_DR_CONNECTOR_TYPE_PCI:

        rc = !((drc->isolation_state == SPAPR_DR_ISOLATION_STATE_UNISOLATED) &&

               (drc->allocation_state == SPAPR_DR_ALLOCATION_STATE_USABLE) &&

               drc->configured && drc->signalled && !drc->awaiting_release);

        break;

    case SPAPR_DR_CONNECTOR_TYPE_CPU:

    case SPAPR_DR_CONNECTOR_TYPE_LMB:

        rc = !((drc->isolation_state == SPAPR_DR_ISOLATION_STATE_ISOLATED) &&

               (drc->allocation_state == SPAPR_DR_ALLOCATION_STATE_UNUSABLE) &&

        rc = !((drc->isolation_state == SPAPR_DR_ISOLATION_STATE_UNISOLATED) &&

               (drc->allocation_state == SPAPR_DR_ALLOCATION_STATE_USABLE) &&

               drc->configured && drc->signalled && !drc->awaiting_release);

        break;

    case SPAPR_DR_CONNECTOR_TYPE_PHB:

    case SPAPR_DR_CONNECTOR_TYPE_VIO:

    default:

        g_assert(false);

        g_assert_not_reached();

    }

    return rc;

}