Commit a2ec6be7 authored Aug 23, 2018 by Markus Armbruster

json: Fix lexer to include the bad character in JSON_ERROR token



json_lexer[] maps (lexer state, input character) to the new lexer
state.  The input character is consumed unless the new state is
terminal and the input character doesn't belong to this token,
i.e. the state transition uses look-ahead.  When this is the case,
input character '\0' would result in the same state transition.
TERMINAL_NEEDED_LOOKAHEAD() exploits this.

Except this is wrong for transitions to IN_ERROR.  There, the
offending input character is in fact consumed: case IN_ERROR returns.
It isn't added to the JSON_ERROR token, though.

Fix that by making TERMINAL_NEEDED_LOOKAHEAD() return false for
transitions to IN_ERROR.

There's a slight complication.  json_lexer_flush() passes input
character '\0' to flush an incomplete token.  If this results in
JSON_ERROR, we'd now add the '\0' to the token.  Suppress that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180823164025.12553-18-armbru@redhat.com>

parent 2e933f57

qobject/json-lexer.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -76,7 +76,7 @@ QEMU_BUILD_BUG_ON((int)JSON_MIN <= (int)IN_START);
		from OLD_STATE required lookahead. This happens whenever the table
		below uses the TERMINAL macro. */
		#define TERMINAL_NEEDED_LOOKAHEAD(old_state, terminal) \
		(json_lexer[(old_state)][0] == (terminal))
		(terminal != IN_ERROR && json_lexer[(old_state)][0] == (terminal))

		static const uint8_t json_lexer[][256] = {
		/* Relies on default initialization to IN_ERROR! */
		@@ -304,7 +304,7 @@ static int json_lexer_feed_char(JSONLexer *lexer, char ch, bool flush)
		assert(lexer->state <= ARRAY_SIZE(json_lexer));
		new_state = json_lexer[lexer->state][(uint8_t)ch];
		char_consumed = !TERMINAL_NEEDED_LOOKAHEAD(lexer->state, new_state);
		if (char_consumed) {
		if (char_consumed && !flush) {
		g_string_append_c(lexer->token, ch);
		}