Commit a1c59752 authored by Amit Shah's avatar Amit Shah Committed by Anthony Liguori
Browse files

virtio-serial: Fix check for 'assert'; prevent NULL derefs 



In the flush_queued_data() function, we expect port to be valid. Assert
only for port and not port || discard.

Reported-by: default avatarJuan Quintela <quintela@redhat.com>
Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent f8778a77

hw/virtio-serial-bus.c

+1 −1
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port, VirtQueue *vq, 


static void flush_queued_data(VirtIOSerialPort *port, bool discard)

{

    assert(port || discard);

    assert(port);



    do_flush_queued_data(port, port->ovq, &port->vser->vdev, discard);

}