Commit a04eca10 authored by Vishvananda Ishaya's avatar Vishvananda Ishaya Committed by Stefan Hajnoczi
Browse files

block: Adds mirroring tests for resized images 



This test verifies two mirroring issues are fixed with resized images:

 * sync='top' creates an image that is the proper size
 * sync='full' doesn't cause an assertion failure and crash qemu
Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>

Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 63ba17d3

tests/qemu-iotests/041

+48 −0
Original line number Diff line number Diff line
@@ -344,6 +344,54 @@ class TestMirrorNoBacking(ImageMirroringTestCase): 
        self.assertTrue(self.compare_images(test_img, target_img),

                        'target image does not match source after mirroring')



class TestMirrorResized(ImageMirroringTestCase):

    backing_len = 1 * 1024 * 1024 # MB

    image_len = 2 * 1024 * 1024 # MB



    def setUp(self):

        self.create_image(backing_img, TestMirrorResized.backing_len)

        qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % backing_img, test_img)

        qemu_img('resize', test_img, '2M')

        self.vm = iotests.VM().add_drive(test_img)

        self.vm.launch()



    def tearDown(self):

        self.vm.shutdown()

        os.remove(test_img)

        os.remove(backing_img)

        try:

            os.remove(target_img)

        except OSError:

            pass



    def test_complete_top(self):

        self.assert_no_active_mirrors()



        result = self.vm.qmp('drive-mirror', device='drive0', sync='top',

                             target=target_img)

        self.assert_qmp(result, 'return', {})



        self.complete_and_wait()

        result = self.vm.qmp('query-block')

        self.assert_qmp(result, 'return[0]/inserted/file', target_img)

        self.vm.shutdown()

        self.assertTrue(self.compare_images(test_img, target_img),

                        'target image does not match source after mirroring')



    def test_complete_full(self):

        self.assert_no_active_mirrors()



        result = self.vm.qmp('drive-mirror', device='drive0', sync='full',

                             target=target_img)

        self.assert_qmp(result, 'return', {})



        self.complete_and_wait()

        result = self.vm.qmp('query-block')

        self.assert_qmp(result, 'return[0]/inserted/file', target_img)

        self.vm.shutdown()

        self.assertTrue(self.compare_images(test_img, target_img),

                        'target image does not match source after mirroring')



class TestReadErrors(ImageMirroringTestCase):

    image_len = 2 * 1024 * 1024 # MB

tests/qemu-iotests/041.out

+2 −2
Original line number Diff line number Diff line 
......................

........................

----------------------------------------------------------------------

Ran 22 tests

Ran 24 tests



OK