Commit 9ed26903 authored by Paolo Bonzini's avatar Paolo Bonzini Committed by Michael Tokarev
Browse files

pci-assign: avoid pointless stat 



Just check the errno value after fopen and follow it with fstat.
This shuts up Coverity's complaint about TOC/TOU violation.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent ece9086e

hw/i386/pci-assign-load-rom.c

+8 −8
Original line number Diff line number Diff line
@@ -39,19 +39,19 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, struct Object *owner, 
             "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/rom",

             domain, bus, slot, function);



    if (stat(rom_file, &st)) {

        if (errno != ENOENT) {

            error_report("pci-assign: Invalid ROM.");

        }

        return NULL;

    }



    /* Write "1" to the ROM file to enable it */

    fp = fopen(rom_file, "r+");

    if (fp == NULL) {

        if (errno != ENOENT) {

            error_report("pci-assign: Cannot open %s: %s", rom_file, strerror(errno));

        }

        return NULL;

    }

    if (fstat(fileno(fp), &st) == -1) {

        error_report("pci-assign: Cannot stat %s: %s", rom_file, strerror(errno));

        goto close_rom;

    }



    val = 1;

    if (fwrite(&val, 1, 1, fp) != 1) {

        goto close_rom;