Commit 9e84a470 authored by Blue Swirl's avatar Blue Swirl
Browse files

etraxfs_eth: correct use of ! and & 

Combining bitwise AND and logical NOT is suspicious.

Fixed by this Coccinelle script:
// From http://article.gmane.org/gmane.linux.kernel/646367


@@ expression E1,E2; @@
(
 !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)

Acked-by: default avatarEdgar E. Iglesias <edgar.iglesias@gmail.com>
Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
parent 8aa80ff8

hw/etraxfs_eth.c

+1 −1
Original line number Diff line number Diff line
@@ -464,7 +464,7 @@ static int eth_match_groupaddr(struct fs_eth *eth, const unsigned char *sa) 


	/* First bit on the wire of a MAC address signals multicast or

	   physical address.  */

	if (!m_individual && !sa[0] & 1)

	if (!m_individual && !(sa[0] & 1))

		return 0;



	/* Calculate the hash index for the GA registers. */