Commit 9cd9cdae authored by David Hildenbrand's avatar David Hildenbrand Committed by Richard Henderson
Browse files

s390x/tcg: Pass a size to probe_write() in do_csst() 



... and also call it for CONFIG_USER_ONLY. This function probably will
also need some refactoring in regards to probing, however, we'll have to
come back to that later, once cleaning up the other mem helpers.

The alignment check always makes sure that the write access falls into a
single page.

Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <20190826075112.25637-8-david@redhat.com>
Signed-off-by: default avatarRichard Henderson <richard.henderson@linaro.org>
parent 200aa7a5

target/s390x/mem_helper.c

+1 −3
Original line number Diff line number Diff line
@@ -1443,9 +1443,7 @@ static uint32_t do_csst(CPUS390XState *env, uint32_t r3, uint64_t a1, 
    }



    /* Sanity check writability of the store address.  */

#ifndef CONFIG_USER_ONLY

    probe_write(env, a2, 0, mem_idx, ra);

#endif

    probe_write(env, a2, 1 << sc, mem_idx, ra);



    /*

     * Note that the compare-and-swap is atomic, and the store is atomic,