Commit 9cc0f19d authored by Fam Zheng's avatar Fam Zheng Committed by Stefan Hajnoczi
Browse files

iotests: Add regresion test case for write notifier assertion failure 



The idea is to let the top level bs have a big request alignment with
blkdebug, so that the aio_write request issued from monitor will be
serialised. This tests that QEMU doesn't crash upon the read request
from the backup job's write notifier, which is a very special case of
"reentrant" request.

Signed-off-by: default avatarFam Zheng <famz@redhat.com>
Message-id: 1448962590-2842-4-git-send-email-famz@redhat.com
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 78b666f4

tests/qemu-iotests/056

+25 −0
Original line number Diff line number Diff line
@@ -82,6 +82,31 @@ class TestSyncModesNoneAndTop(iotests.QMPTestCase): 
        time.sleep(1)

        self.assertEqual(-1, qemu_io('-c', 'read -P0x41 0 512', target_img).find("verification failed"))



class TestBeforeWriteNotifier(iotests.QMPTestCase):

    def setUp(self):

        self.vm = iotests.VM().add_drive_raw("file=blkdebug::null-co://,id=drive0,align=65536,driver=blkdebug")

        self.vm.launch()



    def tearDown(self):

        self.vm.shutdown()

        os.remove(target_img)



    def test_before_write_notifier(self):

        self.vm.pause_drive("drive0")

        result = self.vm.qmp('drive-backup', device='drive0',

                             sync='full', target=target_img,

                             format="file", speed=1)

        self.assert_qmp(result, 'return', {})

        result = self.vm.qmp('block-job-pause', device="drive0")

        self.assert_qmp(result, 'return', {})

        # Speed is low enough that this must be an uncopied range, which will

        # trigger the before write notifier

        self.vm.hmp_qemu_io('drive0', 'aio_write -P 1 512512 512')

        self.vm.resume_drive("drive0")

        result = self.vm.qmp('block-job-resume', device="drive0")

        self.assert_qmp(result, 'return', {})

        event = self.cancel_and_wait()

        self.assert_qmp(event, 'data/type', 'backup')



if __name__ == '__main__':

    iotests.main(supported_fmts=['qcow2', 'qed'])

tests/qemu-iotests/056.out

+2 −2
Original line number Diff line number Diff line 
..

...

----------------------------------------------------------------------

Ran 2 tests

Ran 3 tests



OK