Commit 9c2762b4 authored Oct 19, 2018 by Max Reitz Committed by Kevin Wolf Nov 05, 2018

qdev-monitor: Make device options help nicer

Just like in qemu_opts_print_help(), print the device name as a caption
instead of on every single line, indent all options, add angle brackets
around types, and align the descriptions after 24 characters. Also,
separate the descriptions with " - " instead of putting them in
parentheses, because that is what we do everywhere else. This does look
a bit funny here because basically all bits have the description
"on/off", but funny does not mean it is less readable.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>

parent 8513ec28

qdev-monitor.c

+11 −2

Original line number	Diff line number	Diff line
		@@ -285,10 +285,19 @@ int qdev_device_help(QemuOpts *opts)
		goto error;
		}

		if (prop_list) {
		out_printf("%s options:\n", driver);
		} else {
		out_printf("There are no options for %s.\n", driver);
		}
		for (prop = prop_list; prop; prop = prop->next) {
		out_printf("%s.%s=%s", driver, prop->value->name, prop->value->type);
		int len;
		out_printf(" %s=<%s>%n", prop->value->name, prop->value->type, &len);
		if (prop->value->has_description) {
		out_printf(" (%s)\n", prop->value->description);
		if (len < 24) {
		out_printf("%*s", 24 - len, "");
		}
		out_printf(" - %s\n", prop->value->description);
		} else {
		out_printf("\n");
		}