Commit 9c041885 authored by Igor Mammedov's avatar Igor Mammedov Committed by Michael S. Tsirkin
Browse files

tests: acpi: make pointer to RSDP 64bit 



In case of UEFI, RSDP doesn't have to be located in lowmem,
it could be placed at any address. Make sure that test won't
break if it is placed above the first 4Gb of address space.

PS:
While at it cleanup some local variables as we don't really
need them.

Signed-off-by: default avatarIgor Mammedov <imammedo@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <1556808723-226478-5-git-send-email-imammedo@redhat.com>
Reviewed-by: default avatarWei Yang <richardw.yang@linux.intel.com>
Tested-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent f2f616ce

tests/acpi-utils.c

+1 −1
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ uint32_t acpi_find_rsdp_address(QTestState *qts) 
    return off;

}



void acpi_fetch_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table)

void acpi_fetch_rsdp_table(QTestState *qts, uint64_t addr, uint8_t *rsdp_table)

{

    uint8_t revision;

tests/acpi-utils.h

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ typedef struct { 


uint8_t acpi_calc_checksum(const uint8_t *data, int len);

uint32_t acpi_find_rsdp_address(QTestState *qts);

void acpi_fetch_rsdp_table(QTestState *qts, uint32_t addr, uint8_t *rsdp_table);

void acpi_fetch_rsdp_table(QTestState *qts, uint64_t addr, uint8_t *rsdp_table);

void acpi_fetch_table(QTestState *qts, uint8_t **aml, uint32_t *aml_len,

                      const uint8_t *addr_ptr, int addr_size, const char *sig,

                      bool verify_checksum);

tests/bios-tables-test.c

+4 −6
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 
typedef struct {

    const char *machine;

    const char *variant;

    uint32_t rsdp_addr;

    uint64_t rsdp_addr;

    uint8_t rsdp_table[36 /* ACPI 2.0+ RSDP size */];

    GArray *tables;

    uint32_t smbios_ep_addr;
@@ -86,13 +86,11 @@ static void test_acpi_rsdp_address(test_data *data) 


static void test_acpi_rsdp_table(test_data *data)

{

    uint8_t *rsdp_table = data->rsdp_table, revision;

    uint32_t addr = data->rsdp_addr;

    uint8_t *rsdp_table = data->rsdp_table;



    acpi_fetch_rsdp_table(data->qts, addr, rsdp_table);

    revision = rsdp_table[15 /* Revision offset */];

    acpi_fetch_rsdp_table(data->qts, data->rsdp_addr, rsdp_table);



    switch (revision) {

    switch (rsdp_table[15 /* Revision offset */]) {

    case 0: /* ACPI 1.0 RSDP */

        /* With rev 1, checksum is only for the first 20 bytes */

        g_assert(!acpi_calc_checksum(rsdp_table,  20));