Commit 9a93b2fa authored by Prasad J Pandit's avatar Prasad J Pandit Committed by Peter Maydell
Browse files

strongarm: mask off high[31:28] bits from dir and state registers 



The high[31:28] bits of 'direction' and 'state' registers of
SA-1100/SA-1110 device are reserved. Setting them may lead to
OOB 's->handler[]' array access issue. Mask off [31:28] bits to
avoid it.

Reported-by: default avatarMoguofang <moguofang@huawei.com>
Signed-off-by: default avatarPrasad J Pandit <pjp@fedoraproject.org>
Message-id: 20181030114635.31232-1-ppandit@redhat.com
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 22461bd2

hw/arm/strongarm.c

+2 −2
Original line number Diff line number Diff line
@@ -587,12 +587,12 @@ static void strongarm_gpio_write(void *opaque, hwaddr offset, 


    switch (offset) {

    case GPDR:        /* GPIO Pin-Direction registers */

        s->dir = value;

        s->dir = value & 0x0fffffff;

        strongarm_gpio_handler_update(s);

        break;



    case GPSR:        /* GPIO Pin-Output Set registers */

        s->olevel |= value;

        s->olevel |= value & 0x0fffffff;

        strongarm_gpio_handler_update(s);

        break;