Commit 99372e78 authored by Greg Kurz's avatar Greg Kurz Committed by David Gibson
Browse files

spapr_pci: use the common _FDT() helper 



All other users in hw/ppc already consider an error when building
the FDT to be fatal, even on hotplug paths. There's no valid reason
for spapr_pci to behave differently. So let's used the common _FDT()
helper which terminates QEMU when libfdt fails.

Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 30bf9ed1

hw/ppc/spapr_pci.c

+1 −9
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ 
#include "trace.h"

#include "qemu/error-report.h"

#include "qapi/qmp/qerror.h"



#include "hw/ppc/fdt.h"

#include "hw/pci/pci_bridge.h"

#include "hw/pci/pci_bus.h"

#include "hw/pci/pci_ids.h"
@@ -61,14 +61,6 @@ 
#define RTAS_TYPE_MSI           1

#define RTAS_TYPE_MSIX          2



#define _FDT(exp) \

    do { \

        int ret = (exp);                                           \

        if (ret < 0) {                                             \

            return ret;                                            \

        }                                                          \

    } while (0)



sPAPRPHBState *spapr_pci_find_phb(sPAPRMachineState *spapr, uint64_t buid)

{

    sPAPRPHBState *sphb;