Commit 98ed8ecf authored by Greg Kurz's avatar Greg Kurz Committed by Michael S. Tsirkin
Browse files

exec: introduce target_words_bigendian() helper 



We currently have a virtio_is_big_endian() helper that provides the target
endianness to the virtio code. As of today, the helper returns a fixed
compile-time value. Of course, this will have to change if we want to
support target endianness changes at run-time.

Let's move the TARGET_WORDS_BIGENDIAN bits out to a new helper and have
virtio_is_big_endian() implemented on top of it.

This patch doesn't change any functionality.

Signed-off-by: default avatarGreg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 6b321a3d

exec.c

+2 −6
Original line number Diff line number Diff line
@@ -2759,14 +2759,12 @@ int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, 
}

#endif



#if !defined(CONFIG_USER_ONLY)



/*

 * A helper function for the _utterly broken_ virtio device model to find out if

 * it's running on a big endian machine. Don't do this at home kids!

 */

bool virtio_is_big_endian(void);

bool virtio_is_big_endian(void)

bool target_words_bigendian(void);

bool target_words_bigendian(void)

{

#if defined(TARGET_WORDS_BIGENDIAN)

    return true;
@@ -2775,8 +2773,6 @@ bool virtio_is_big_endian(void) 
#endif

}



#endif



#ifndef CONFIG_USER_ONLY

bool cpu_physical_memory_is_io(hwaddr phys_addr)

{

hw/virtio/virtio-pci.c

+0 −3
Original line number Diff line number Diff line
@@ -89,9 +89,6 @@ 
/* Flags track per-device state like workarounds for quirks in older guests. */

#define VIRTIO_PCI_FLAG_BUS_MASTER_BUG  (1 << 0)



/* HACK for virtio to determine if it's running a big endian guest */

bool virtio_is_big_endian(void);



static void virtio_pci_bus_new(VirtioBusState *bus, size_t bus_size,

                               VirtIOPCIProxy *dev);

include/hw/virtio/virtio.h

+6 −0
Original line number Diff line number Diff line
@@ -255,4 +255,10 @@ void virtio_queue_set_host_notifier_fd_handler(VirtQueue *vq, bool assign, 
                                               bool set_handler);

void virtio_queue_notify_vq(VirtQueue *vq);

void virtio_irq(VirtQueue *vq);



bool target_words_bigendian(void);

static inline bool virtio_is_big_endian(void)

{

    return target_words_bigendian();

}

#endif