Commit 981fdf23 authored by Juan Quintela's avatar Juan Quintela
Browse files

memory: cpu_physical_memory_set_dirty_tracking() should return void 



Result was always 0, and not used anywhere.  Once there, use bool type
for the parameter.

Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarOrit Wasserman <owasserm@redhat.com>
parent a2f4d5be

exec.c

+4 −6
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ 
//#define DEBUG_SUBPAGE



#if !defined(CONFIG_USER_ONLY)

static int in_migration;

static bool in_migration;



RAMList ram_list = { .blocks = QTAILQ_HEAD_INITIALIZER(ram_list.blocks) };
@@ -752,11 +752,9 @@ void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t length, 
    }

}



static int cpu_physical_memory_set_dirty_tracking(int enable)

static void cpu_physical_memory_set_dirty_tracking(bool enable)

{

    int ret = 0;

    in_migration = enable;

    return ret;

}



hwaddr memory_region_section_get_iotlb(CPUArchState *env,
@@ -1798,12 +1796,12 @@ static void tcg_commit(MemoryListener *listener) 


static void core_log_global_start(MemoryListener *listener)

{

    cpu_physical_memory_set_dirty_tracking(1);

    cpu_physical_memory_set_dirty_tracking(true);

}



static void core_log_global_stop(MemoryListener *listener)

{

    cpu_physical_memory_set_dirty_tracking(0);

    cpu_physical_memory_set_dirty_tracking(false);

}



static MemoryListener core_memory_listener = {