Commit 97aa6e9b authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

qdev: accept hex properties only if prefixed by 0x 



Hex properties are an obstacle to removal of old qdev string parsing, but
even here we can lay down the foundations for future simplification.  In
general, they are rarely used and their printed form is more interesting
than the parsing.  For example you'd usually set isa-serial.index
instead of isa-serial.iobase.  And luckily our main client, libvirt
only cares about few of these, and always sets them with a 0x prefix.
So the series stops accepting bare hexadecimal numbers, preparing for
making legacy properties read-only in 1.3 or so.  The read side will
stay as long as "info qtree" is with us.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 768a9ebe

hw/qdev-properties.c

+12 −0
Original line number Diff line number Diff line
@@ -164,6 +164,10 @@ static int parse_hex8(DeviceState *dev, Property *prop, const char *str) 
    uint8_t *ptr = qdev_get_prop_ptr(dev, prop);

    char *end;



    if (str[0] != '0' || str[1] != 'x') {

        return -EINVAL;

    }



    *ptr = strtoul(str, &end, 16);

    if ((*end != '\0') || (end == str)) {

        return -EINVAL;
@@ -369,6 +373,10 @@ static int parse_hex32(DeviceState *dev, Property *prop, const char *str) 
    uint32_t *ptr = qdev_get_prop_ptr(dev, prop);

    char *end;



    if (str[0] != '0' || str[1] != 'x') {

        return -EINVAL;

    }



    *ptr = strtoul(str, &end, 16);

    if ((*end != '\0') || (end == str)) {

        return -EINVAL;
@@ -456,6 +464,10 @@ static int parse_hex64(DeviceState *dev, Property *prop, const char *str) 
    uint64_t *ptr = qdev_get_prop_ptr(dev, prop);

    char *end;



    if (str[0] != '0' || str[1] != 'x') {

        return -EINVAL;

    }



    *ptr = strtoull(str, &end, 16);

    if ((*end != '\0') || (end == str)) {

        return -EINVAL;