Commit 955e304f authored by Luke Shumaker's avatar Luke Shumaker Committed by Laurent Vivier
Browse files

linux-user: init_guest_commpage: Add a comment about size check 



Signed-off-by: default avatarLuke Shumaker <lukeshu@parabola.nu>
Message-Id: <20171228180814.9749-7-lukeshu@lukeshu.com>
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarLaurent Vivier <laurent@vivier.eu>
parent 293f2060

linux-user/elfload.c

+5 −0
Original line number Diff line number Diff line
@@ -374,6 +374,11 @@ static int init_guest_commpage(unsigned long guest_base, 


    /* If the commpage lies within the already allocated guest space,

     * then there is no way we can allocate it.

     *

     * You may be thinking that that this check is redundant because

     * we already validated the guest size against MAX_RESERVED_VA;

     * but if qemu_host_page_mask is unusually large, then

     * test_page_addr may be lower.

     */

    if (test_page_addr >= guest_base

        && test_page_addr < (guest_base + guest_size)) {