Commit 94aaca64 authored by Daniel P. Berrangé's avatar Daniel P. Berrangé Committed by Michael S. Tsirkin
Browse files

acpi: avoid potential uninitialized access to cpu_hp_io_base 



When building QEMU with Mingw64 toolchain I see a warning

 CC    x86_64-softmmu/hw/i386/acpi-build.o
  hw/i386/acpi-build.c: In function 'acpi_build':
  hw/i386/acpi-build.c:1138:9: warning: 'pm.cpu_hp_io_base' may be used uninitialized in this function [-Wmaybe-uninitialized]
           aml_append(crs,
           ^
  hw/i386/acpi-build.c:1666:16: note: 'pm.cpu_hp_io_base' was declared here
       AcpiPmInfo pm;
                  ^

In acpi_get_pm_info() some of the fields are pre-initialized
to 0, but this one was missed.

Signed-off-by: default avatarDaniel P. Berrange <berrange@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
parent bd89dd98

hw/i386/acpi-build.c

+1 −0
Original line number Diff line number Diff line
@@ -169,6 +169,7 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) 
    Object *obj = NULL;

    QObject *o;



    pm->cpu_hp_io_base = 0;

    pm->pcihp_io_base = 0;

    pm->pcihp_io_len = 0;

    if (piix) {