Commit 94530926 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Laurent Vivier
Browse files

hw/arm/virt: Remove null-check in virt_build_smbios() 



Since commit 578f3c7b ("arm: add fw_cfg to "virt" board",
2014-12-22), the machvirt_init() unconditionally creates the
fw_cfg object.  Later, commit c30e1565 ("smbios: implement
smbios support for mach-virt", 2015-09-07) added a superfluous
null-check on it.
Remove this superfluous check.

Reviewed-by: default avatarLaszlo Ersek <lersek@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190309181920.30553-2-philmd@redhat.com>
Signed-off-by: default avatarLaurent Vivier <laurent@vivier.eu>
parent 4a90846d

hw/arm/virt.c

+0 −4
Original line number Diff line number Diff line
@@ -1281,10 +1281,6 @@ static void virt_build_smbios(VirtMachineState *vms) 
    size_t smbios_tables_len, smbios_anchor_len;

    const char *product = "QEMU Virtual Machine";



    if (!vms->fw_cfg) {

        return;

    }



    if (kvm_enabled()) {

        product = "KVM Virtual Machine";

    }