Commit 93bf276d authored by Cédric Le Goater's avatar Cédric Le Goater Committed by Peter Maydell
Browse files

aspeed: remove useless comment on controller segment size 



The flash devices used for the FMC controller (BMC firmware) are well
defined for each Aspeed machine and are all smaller than the default
mapping window size, at least for CE0 which is the chip the SoC boots
from.

Signed-off-by: default avatarCédric Le Goater <clg@kaod.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 1486648058-520-3-git-send-email-clg@kaod.org
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 0c7209be

hw/arm/aspeed.c

+3 −5
Original line number Diff line number Diff line
@@ -148,10 +148,6 @@ static void aspeed_board_init_flashes(AspeedSMCState *s, const char *flashtype, 
        DriveInfo *dinfo = drive_get_next(IF_MTD);

        qemu_irq cs_line;



        /*

         * FIXME: check that we are not using a flash module exceeding

         * the controller segment size

         */

        fl->flash = ssi_create_slave_no_init(s->spi, flashtype);

        if (dinfo) {

            qdev_prop_set_drive(fl->flash, "drive", blk_by_legacy_dinfo(dinfo),
@@ -210,7 +206,9 @@ static void aspeed_board_init(MachineState *machine, 


        /*

         * create a ROM region using the default mapping window size of

         * the flash module.

         * the flash module. The window size is 64MB for the AST2400

         * SoC and 128MB for the AST2500 SoC, which is twice as big as

         * needed by the flash modules of the Aspeed machines.

         */

        memory_region_init_rom(boot_rom, OBJECT(bmc), "aspeed.boot_rom",

                               fl->size, &error_abort);