Commit 93725140 authored by Michael S. Tsirkin's avatar Michael S. Tsirkin
Browse files

virtio: allow mapping up to max queue size 



It's a loop from i < num_sg  and the array is VIRTQUEUE_MAX_SIZE - so
it's OK if the value read is VIRTQUEUE_MAX_SIZE.

Not a big problem in practice as people don't use
such big queues, but it's inelegant.

Reported-by: default avatar"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 06b4f00d

hw/virtio/virtio.c

+1 −1
Original line number Diff line number Diff line
@@ -430,7 +430,7 @@ void virtqueue_map_sg(struct iovec *sg, hwaddr *addr, 
    unsigned int i;

    hwaddr len;



    if (num_sg >= VIRTQUEUE_MAX_SIZE) {

    if (num_sg > VIRTQUEUE_MAX_SIZE) {

        error_report("virtio: map attempt out of bounds: %zd > %d",

                     num_sg, VIRTQUEUE_MAX_SIZE);

        exit(1);