Commit 92bed463 authored by Chen Gang S's avatar Chen Gang S Committed by Riku Voipio
Browse files

linux-user/main.c: Remove redundant end_exclusive() in arm_kernel_cmpxchg64_helper() 



start/end_exclusive() need be pairs, except the start_exclusive() in
stop_all_tasks() which is only used by force_sig(), which will be abort.
So at present, start_exclusive() in stop_all_task() need not be paired.

queue_signal() may call force_sig(), or return after kill pid (or queue
signal). If could return from queue_signal(), stop_all_task() would not
be called in time, the next end_exclusive() would be issue.

So in arm_kernel_cmpxchg64_helper() for ARM, need remove end_exclusive()
after queue_signal(). The related commit: "97cc7560 linux-user: Implement
new ARM 64 bit cmpxchg kernel helper".

Signed-off-by: default avatarChen Gang <gang.chen.5i5j@gmail.com>
Signed-off-by: default avatarRiku Voipio <riku.voipio@linaro.org>
parent 3c6c9fe0

linux-user/main.c

+0 −2
Original line number Diff line number Diff line
@@ -525,8 +525,6 @@ segv: 
    info.si_code = TARGET_SEGV_MAPERR;

    info._sifields._sigfault._addr = env->exception.vaddress;

    queue_signal(env, info.si_signo, &info);



    end_exclusive();

}



/* Handle a jump to the kernel code page.  */