Commit 91e7fcca authored by Markus Armbruster's avatar Markus Armbruster Committed by Paolo Bonzini
Browse files

virtio-scsi: Plug memory leak on virtio_scsi_push_event() error path 



Spotted by Coverity.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent c4ce4c4b

hw/scsi/virtio-scsi.c

+2 −1
Original line number Diff line number Diff line
@@ -489,7 +489,7 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev, 
                                   uint32_t event, uint32_t reason)

{

    VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s);

    VirtIOSCSIReq *req = virtio_scsi_pop_req(s, vs->event_vq);

    VirtIOSCSIReq *req;

    VirtIOSCSIEvent *evt;

    VirtIODevice *vdev = VIRTIO_DEVICE(s);

    int in_size;
@@ -498,6 +498,7 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev, 
        return;

    }



    req = virtio_scsi_pop_req(s, vs->event_vq);

    if (!req) {

        s->events_dropped = true;

        return;