Commit 91bdd1cf authored by Amit Shah's avatar Amit Shah
Browse files

virtio-serial-bus: assert port is non-null in remove_port() 



remove_port() is called from qdev's unplug callback, and we're certain
the port will be found in our list of ports.  Adding an assert()
documents this.

This was flagged by Coverity, fix suggested by Markus.

CC: Markus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
parent 4e28976e

hw/virtio-serial-bus.c

+6 −0
Original line number Diff line number Diff line
@@ -852,6 +852,12 @@ static void remove_port(VirtIOSerial *vser, uint32_t port_id) 
    vser->ports_map[i] &= ~(1U << (port_id % 32));



    port = find_port_by_id(vser, port_id);

    /*

     * This function is only called from qdev's unplug callback; if we

     * get a NULL port here, we're in trouble.

     */

    assert(port);



    /* Flush out any unconsumed buffers first */

    discard_vq_data(port->ovq, &port->vser->vdev);