Commit 91ab6883 authored by Kevin Wolf's avatar Kevin Wolf
Browse files

backup: Don't leak BackupBlockJob in error path 



Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Reviewed-by: default avatarAlberto Garcia <berto@igalia.com>
parent e253f4b8

block/backup.c

+5 −2
Original line number Diff line number Diff line
@@ -485,6 +485,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target, 
{

    int64_t len;

    BlockDriverInfo bdi;

    BackupBlockJob *job = NULL;

    int ret;



    assert(bs);
@@ -542,8 +543,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target, 
        goto error;

    }



    BackupBlockJob *job = block_job_create(&backup_job_driver, bs, speed,

                                           cb, opaque, errp);

    job = block_job_create(&backup_job_driver, bs, speed, cb, opaque, errp);

    if (!job) {

        goto error;

    }
@@ -584,4 +584,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target, 
    if (sync_bitmap) {

        bdrv_reclaim_dirty_bitmap(bs, sync_bitmap, NULL);

    }

    if (job) {

        block_job_unref(&job->common);

    }

}