Commit 9183dd15 authored by Vladimir Sementsov-Ogievskiy's avatar Vladimir Sementsov-Ogievskiy Committed by Kevin Wolf
Browse files

qmp: forbid qmp_cont in RUN_STATE_FINISH_MIGRATE 



qmp_cont in RUN_STATE_FINISH_MIGRATE may lead to moving vm to
RUN_STATE_RUNNING, before actual migration finish. So, when migration
thread will try to go to RUN_STATE_POSTMIGRATE, assuming transition
RUN_STATE_FINISH_MIGRATE->RUN_STATE_POSTMIGRATE, it will crash, as
current state is RUN_STATE_RUNNING, and transition
RUN_STATE_RUNNING->RUN_STATE_POSTMIGRATE is forbidden.

Reported-by: default avatarMax Reitz <mreitz@redhat.com>
Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 41ae31e3

qmp.c

+3 −0
Original line number Diff line number Diff line
@@ -156,6 +156,9 @@ void qmp_cont(Error **errp) 
        return;

    } else if (runstate_check(RUN_STATE_SUSPENDED)) {

        return;

    } else if (runstate_check(RUN_STATE_FINISH_MIGRATE)) {

        error_setg(errp, "Migration is not finalized yet");

        return;

    }



    for (blk = blk_next(NULL); blk; blk = blk_next(blk)) {