Commit 909c548c authored by Stefan Hajnoczi's avatar Stefan Hajnoczi Committed by Michael S. Tsirkin
Browse files

virtio: drop unused virtio_device_stop_ioeventfd() function 



virtio_device_stop_ioeventfd() has not been used since commit
310837de ("virtio: introduce
grab/release_ioeventfd to fix vhost") in 2016.

Nowadays ioeventfd is stopped implicitly by the virtio transport when
lifecycle events such as the VM pausing or device unplug occur.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20191021150343.30742-1-stefanha@redhat.com>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent d08f68b8

hw/virtio/virtio.c

+0 −8
Original line number Diff line number Diff line
@@ -3665,14 +3665,6 @@ static void virtio_device_stop_ioeventfd_impl(VirtIODevice *vdev) 
    }

}



void virtio_device_stop_ioeventfd(VirtIODevice *vdev)

{

    BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));

    VirtioBusState *vbus = VIRTIO_BUS(qbus);



    virtio_bus_stop_ioeventfd(vbus);

}



int virtio_device_grab_ioeventfd(VirtIODevice *vdev)

{

    BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));

include/hw/virtio/virtio.h

+0 −1
Original line number Diff line number Diff line
@@ -308,7 +308,6 @@ EventNotifier *virtio_queue_get_guest_notifier(VirtQueue *vq); 
void virtio_queue_set_guest_notifier_fd_handler(VirtQueue *vq, bool assign,

                                                bool with_irqfd);

int virtio_device_start_ioeventfd(VirtIODevice *vdev);

void virtio_device_stop_ioeventfd(VirtIODevice *vdev);

int virtio_device_grab_ioeventfd(VirtIODevice *vdev);

void virtio_device_release_ioeventfd(VirtIODevice *vdev);

bool virtio_device_ioeventfd_enabled(VirtIODevice *vdev);